Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide test_filter players_by_event into smaller tests in game_event_player/tests.pay #52

Open
amitkaplansky opened this issue Apr 20, 2023 · 0 comments

Comments

@amitkaplansky
Copy link
Collaborator

amitkaplansky commented Apr 20, 2023

To improve readability, there’s a need to divide this test into three functions:

  1. function for creating GameEventPlayers.
  2. A function that will test whether a player is in the expected events.
  3. A function that will test whether an event has the expected players.

In this way every function will be smaller, easier to read and understand.

@amitkaplansky amitkaplansky changed the title Divide test_filter players_by_event into smaller tests in game- Divide test_filter players_by_event into smaller tests in game_event_player/tests.pay Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant