add add policy function and ordering the home & layout #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will be in all pages
DoRTaL94
reviewed
May 7, 2020
RoniRush
approved these changes
May 9, 2020
There was a problem hiding this comment.
Few notes for next time -
-
I personally recommend to add more comments in the code OR give more significants names to variables and functions ( for example a variable called "ac" for "air-conditioner", for other people and even for you in the future, it might be a bit complicated to understand what's this variable stands for)
-
I think this PR is a little bit big, I'm sure there was a way to split it , even 2 PR's instead of one
over-all I think you did an AWSOME job !
LGTM :)
|
OK, thanks! I will be on this now ,and yes the PR was a big one, I now know for the future to split the PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the add policy function and ordering the layout & home page that all pages will be in footer.
I also change the version of the jQuaey because the post function didn't succeeded in jQuery slim version.