Extra vars yaml issue

[przemkalit]

Summary

Hey,

There is an issue with exporting the extra vars, it is changing the order of variables in structure to alphabetical. Moreover it sometimes do something like this (probably because of rearranging variables):

From what I've tested the culprit is the from_yaml | to_nice_yaml(indent=2)

Issue Type

• Bug Report

Ansible, Collection, Controller details

Current versions

OS / ENVIRONMENT

RH9

Desired Behavior

Extra vars are properly exported.

Actual Behavior

Source extra vars:

_job_events_use_cases:
  - name: unknown use case
    when:
      matches:
        - unknown use case - no match found with knowledge database
    actions:
      - >-
        just an example
  - name: '!well-known use case, no action needed'
    when:
      matches:
        - 'account_name .+ is not a valid account, cannot get SID'
    actions:
      - >-
        another example

Exported extra_vars:

_job_events_use_cases:
  - actions:
      - >-
        just an example
    name: unknown use case
    when:
      matches:
        - unknown use case - no match found with knowledge database
  - actions:
      - >-
        another example
    name: '!well-known use case, no action needed'
    when:
      matches:
        - account_name .+ is not a valid account, cannot get SID

STEPS TO REPRODUCE

1. Create JT with long list of extra vars provided in source example
2. Export the JT with filetree_create

[przemkalit]

The questions are:

• should collection preserve the state of extra vars?
• or should be modified like in the current state?

[przemkalit]

I am proposing this change to preserve the state of extra_vars, let me now if you don't mind, then I will create PR.

     extra_vars: {{ template_overrides_dynamic.job_template[current_job_templates_asset_value.name].extra_var
         | default(template_overrides_static.job_template.extra_vars)
         | default(current_job_templates_asset_value.extra_vars)
         | regex_replace('^---\n?', '', multiline=True)
         | indent(width=6, first=False)
         | regex_replace('(^[^:]*): (.*){{', '\\1: !unsafe \\2{{', multiline=True)
      }}

[przemkalit]

Please ignore the last message, I will introudce PR with sort_keys=False in to_nice_yaml.