Fix hostfilter and add missing unsafe regex #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemkalit
requested review from
silvinux,
ivarmu,
adonisgarciac and
a team
as code owners
|
I've added missing sort keys for notification that I clearly overlooked. |
ivarmu
requested changes
Nov 13, 2024
roles/filetree_create/templates/current_workflow_job_templates.j2
Outdated
Show resolved
Hide resolved
roles/filetree_create/templates/current_workflow_job_templates.j2
Outdated
Show resolved
Hide resolved
ivarmu
requested changes
Nov 15, 2024
roles/filetree_create/templates/controller_inventory_sources.j2
Outdated
Show resolved
Hide resolved
|
I've added one overlooked sort_keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is fixing two issues:
The host filter for the smart inventory is not properly exported. When you export a smart inventory, it is wrapped in double quotes, but the filter itself is also exported with internal double quotes, making it impossible to import.
Add missing regex_replace to every item that could have a variable.
How should this be tested?
Manually
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A