Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default values that contains a new line #23

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

ivarmu
Copy link
Contributor

@ivarmu ivarmu commented Nov 5, 2024

What does this PR do?

Fixes #8

How should this be tested?

Manually tested.

Is there a relevant Issue open for this?

resolves #8

Other Relevant info, PRs, etc

N/A

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemkalit
Copy link
Contributor

przemkalit commented Nov 7, 2024

Hey, I appreciate the change for my issue, I would like use this PR as opportunity to fix one thing if it is possible, there is small issue related to extra_data of survey in WF.

{{ node.extra_data | to_nice_yaml | indent(10) | replace("'{{", "!unsafe \'{{") | replace("$encrypted$", "")

In result the encrypted is changed into nothing - which break the import, so I proposing this change.

{{ node.extra_data | to_nice_yaml | indent(10) | replace("'{{", "!unsafe \'{{") | replace("$encrypted$", "''") | replace("'", '"') }}

As the survey will use ", I am replacing ' into ", as in survey.

@djdanielsson
Copy link
Contributor

I also think if you rebase it should fix the CI

@ivarmu
Copy link
Contributor Author

ivarmu commented Nov 11, 2024

Hey, I appreciate the change for my issue, I would like use this PR as opportunity to fix one thing if it is possible, there is small issue related to extra_data of survey in WF.

{{ node.extra_data | to_nice_yaml | indent(10) | replace("'{{", "!unsafe \'{{") | replace("$encrypted$", "")

In result the encrypted is changed into nothing - which break the import, so I proposing this change.

{{ node.extra_data | to_nice_yaml | indent(10) | replace("'{{", "!unsafe \'{{") | replace("$encrypted$", "''") | replace("'", '"') }}

As the survey will use ", I am replacing ' into ", as in survey.

I've replaced the "" with "\'\'" everywhere $encrypted was replaced.

@ivarmu ivarmu requested a review from djdanielsson November 11, 2024 08:54
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 8087e88 into redhat-cop:devel Nov 11, 2024
9 checks passed
@ivarmu ivarmu deleted the issue8 branch November 29, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export/Import survey multiple choice issue
3 participants