Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inventory file mode 600 #238

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

dbk-rabel
Copy link
Contributor

The inventory file that aap_setup_prepare generates contains a lot of credentials, but has very unsafe permissions (664) at the moment.

This commit changes it to 600 permissions.

fixes #237

The inventory file that aap_setup_prepare generates contains a lot of credentials, but has very unsafe permissions (664) at the moment.

This commit changes it to 600 permissions.

fixes redhat-cop#237
@djdanielsson
Copy link
Contributor

I am trying to think of any scenario where this could break something

@dbk-rabel
Copy link
Contributor Author

I am trying to think of any scenario where this could break something

Well, theoretically someone could try to start setup.sh with a different user. So in theory it could break something.

But I guess thats very uncommon. If people use aap_setup_prepare, they probably also use aap_setup_install and will therefore probably use the same ansible user.

@djdanielsson
Copy link
Contributor

djdanielsson commented Jun 13, 2024

yea I had a similar thought... how about this change it to 640 and we go with that? that way if someone wants to use a different user to deploy or something they could just add them to the same group and it should just work

@dbk-rabel
Copy link
Contributor Author

yea I had a similar thought... how about this change it to 640 and we go with that? that way if someone wants to use a different user to deploy or something they could just add them to the same group and it should just work

Yes, that should also be fine. :)

@djdanielsson djdanielsson enabled auto-merge (squash) June 17, 2024 13:03
Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit 363d113 into redhat-cop:devel Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inventory file is world-readable - Can we make it only user-readable?
2 participants