Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block and task to revoke Openshift token in aap_ocp_install role #194

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

rev3r4nt
Copy link
Contributor

What does this PR do?

In aap_ocp_install role, added a block and a task to revoke Openshift API token.

Other Relevant info, PRs, etc

⚠️ There's a open PR in community.okd (openshift/community.okd/pull/194) to fix intermittent failures when deleting tokens.

Copy link
Collaborator

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@branic
Copy link
Collaborator

branic commented Sep 12, 2023

@rev3r4nt Thanks for the PR. This is a good addition.

@branic
Copy link
Collaborator

branic commented Sep 12, 2023

Pre-commit is failing, please address the failure and then once the CI passes I'll merge.

@rev3r4nt
Copy link
Contributor Author

Thanks @branic it's corrected 👌🏼

@branic branic merged commit 7890a0b into redhat-cop:devel Sep 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants