Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit instructions about metrics configuration? #311

Open
simonpasquier opened this issue Mar 8, 2024 · 0 comments
Open

Revisit instructions about metrics configuration? #311

simonpasquier opened this issue Mar 8, 2024 · 0 comments

Comments

@simonpasquier
Copy link

redhat-cop/resource-locker-operator#68 (comment)

The instructions at https://github.com/redhat-cop/group-sync-operator#metrics are problematic for a couple of reasons:

  • Only namespaces of OCP "core" and Red Hat certified components are supposed to be labeled with openshift.io/cluster-monitoring="true" . Anything else should be scraped by the user-defined monitoring stack or a custom deployed Prometheus. The current advice goes against the support conditions, meaning that we could consider the cluster to be unsupported.
  • If a user "forgets" to label the namespace and user-defined monitoring is enabled, the PrometheusOperatorRejectedResources alert will fire because the service monitor uses bearerTokenFile which is forbidden in this case (to avoid users getting access to the service account's token).
  • Managed OpenShift (OSD, ROSA) forbids non-platform namespaces from being labeled with openshift.io/cluster-monitoring="true".

A better solution would be to support user-defined monitoring.

cc @jan--f @coffeegoesincodecomesout @w1dg3r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant