Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught error when deleting locally added extension in pr check #245

Open
odockal opened this issue Nov 7, 2024 · 0 comments
Open

Uncaught error when deleting locally added extension in pr check #245

odockal opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
kind/bug 🐞 Something isn't working

Comments

@odockal
Copy link

odockal commented Nov 7, 2024

There is a new PR check job running e2e tests for locally built extension (as part of PR check). But there is a problem when removing the extension that is built locally with error:

Uncaught (in promise) Error: ENOTEMPTY: directory not empty, rmdir '/home/odockal/git/podman-desktop-sandbox-ext/tests/playwright/output/sandbox-tests-pd/plugins/extension/node_modules/electron/dist/resources'

I have not found the rmdir reference being used in the extension, so it might come from podman-desktop api. I am not sure why is the content of the node_modules having a problem to remove it.

we can workaround it when we remove that folder ahead of running the tests on pr check. Not sure it that breaks anything.

@odockal odockal added the kind/bug 🐞 Something isn't working label Nov 13, 2024
@odockal odockal moved this to 📋 Backlog in Podman Desktop Planning Nov 20, 2024
@slemeur slemeur moved this from 📋 Backlog to Deferred in Podman Desktop Planning Dec 4, 2024
@slemeur slemeur moved this from Deferred to 📋 Backlog in Podman Desktop Planning Dec 10, 2024
jeffmaury added a commit to jeffmaury/podman-desktop-sandbox-ext that referenced this issue Dec 25, 2024
dgolovin pushed a commit that referenced this issue Jan 3, 2025
Relates to #245

Signed-off-by: Jeff MAURY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants