Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery task relies on count of machines in the inventory #483

Open
akrzos opened this issue May 6, 2024 · 1 comment
Open

Discovery task relies on count of machines in the inventory #483

akrzos opened this issue May 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@akrzos
Copy link
Member

akrzos commented May 6, 2024

The task for waiting to see that all booted machines have become discovered relies on the count of the inventory where as the actual count of machines booted can be controlled via worker_node_count. Given worker_node_count functions for several things such as determining how many machines to put within the worker host group in the inventory and can actually be left unset too, we may want that variable respected fro number of intended hosts to be discovered when it is actually purposefully set. cc @jtaleric

@dbutenhof
Copy link
Collaborator

Test of assumptions and research:

  1. boot_iso does respect worker_node_count, so I think we can't actually expect additional nodes to be booted/discovered when it's set;
  2. We seem to already set max_nodes as a fact in create_inventory, to (worker_node_count + 4) ... which seems like what we'd want, but this would need to be manually set (or calculated elsewhere) for BYOL.

@josecastillolema josecastillolema added the enhancement New feature or request label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants