Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: remove idle connections from pool #651

Closed
rueian opened this issue Oct 25, 2024 · 4 comments
Closed

Feature: remove idle connections from pool #651

rueian opened this issue Oct 25, 2024 · 4 comments
Labels
feature good first issue Good for newcomers

Comments

@rueian
Copy link
Collaborator

rueian commented Oct 25, 2024

Currently connections in the connection pools (spool and dpool) inside a mux will live forever.

It would be nice if we had an option, such as ConnIdleDuration or a better naming, to clean connections that are idle for a long time to reduce memory usage.

@rueian rueian added good first issue Good for newcomers feature labels Oct 25, 2024
@mingdaoy
Copy link
Contributor

Hi @rueian, I'm interested in working on this issue!

@abuzaforfagun
Copy link

I am interested in working on this issue.

@proost
Copy link
Contributor

proost commented Oct 26, 2024

@rueian
Does need option to min size of connection pool? making a new connection is expensive. If all connections is closed, can be harmful to latency sensitive apps. current pool only support cap size.

@rueian
Copy link
Collaborator Author

rueian commented Oct 26, 2024

@rueian Does need option to min size of connection pool? making a new connection is expensive. If all connections is closed, can be harmful to latency sensitive apps. current pool only support cap size.

Yes, there should be an option for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants