Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed to update build.gradle to work with React Native 0.68 #38

Open
jtklein opened this issue Oct 14, 2022 · 4 comments
Open

Needed to update build.gradle to work with React Native 0.68 #38

jtklein opened this issue Oct 14, 2022 · 4 comments

Comments

@jtklein
Copy link

jtklein commented Oct 14, 2022

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

In order to keep using this package with React Native >= 0.68.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-check-app-install/android/build.gradle b/node_modules/react-native-check-app-install/android/build.gradle
index d374b27..38d9215 100644
--- a/node_modules/react-native-check-app-install/android/build.gradle
+++ b/node_modules/react-native-check-app-install/android/build.gradle
@@ -43,5 +43,5 @@ repositories {
 }
 
 dependencies {
-    compile 'com.facebook.react:react-native:+'
+    implementation 'com.facebook.react:react-native:+'
 }

This issue body was partially generated by patch-package.

@jtklein jtklein changed the title Update build.gradle Needed to update build.gradle t work with React Native 0.68 Oct 14, 2022
@jtklein jtklein changed the title Needed to update build.gradle t work with React Native 0.68 Needed to update build.gradle to work with React Native 0.68 Oct 14, 2022
@c-goettert
Copy link

Would be nice if this patch would find its way into a new release..

@shivendra-parmar
Copy link

I also came across this issue is there a workaround because I have to use this package in my expo app (react-native 0.71)
but the build will fail without this fix

@hfarhanahmed
Copy link

I am also facing this issue, hope this will be updated soon.

@shivendra-parmar
Copy link

React Native Launcher Kit
I found this project that helps in detecting if an app is installed on a user phone or not but project seems to be working for Android only still looking for IOS
Please note that this if you are using expo then you have to use development client to test this
In Expo Go App it doesn't work
Hope it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants