Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP PUT should not merge challenge data #211

Open
ethanwu10 opened this issue Apr 21, 2020 · 0 comments
Open

HTTP PUT should not merge challenge data #211

ethanwu10 opened this issue Apr 21, 2020 · 0 comments
Assignees
@chen-robert
Labels
bug Something isn't working

Comments

@ethanwu10
Copy link
Member

A PUT request should update the resource to the exact contents of its payload; currently, a PUT request to /admin/challs/:id will do a shallow merge with the existing challenge data. Merging functionality should only happen with the PATCH verb.
@ethanwu10 ethanwu10 added the bug Something isn't working label Apr 21, 2020
@ethanwu10 ethanwu10 self-assigned this Apr 21, 2020
@ethanwu10 ethanwu10 removed their assignment Apr 24, 2020
@chen-robert chen-robert self-assigned this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chen-robert chen-robert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanwu10 @chen-robert