Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Use a noop reducer #15

Open
zalmoxisus opened this issue Nov 3, 2016 · 2 comments
Open

Use a noop reducer #15

zalmoxisus opened this issue Nov 3, 2016 · 2 comments

Comments

@zalmoxisus
Copy link
Contributor

I see the reducer is handling TOGGLE_VISIBILITY, but it is not dispatched from anywhere. Is it an orphaned code that should be removed?

@romseguy
Copy link
Collaborator

romseguy commented Nov 4, 2016

Legacy code yes, redux-devtools wasn't implementing visibility state as far as I remember. I don't think we care too much about bundle size since it's a dev tool, so maybe we should just use a noop here instead of removing the reducer and actions files, could make potential future improvements more straightforward... We have git history of course but the convenience here looks free from drawbacks to me.

@zalmoxisus
Copy link
Contributor Author

Of course, if we'll use a noop function and those files won't be imported, it wouldn't affect the bundle size as well. I am working on adding support for monitors reducers into Redux DevTools Extension, and was wondering about extra operations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants