From 6f4abb7b527a916f116c0a646ac622cb41f22aff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Nowacki?= Date: Thu, 23 Nov 2023 21:36:10 +0100 Subject: [PATCH 1/3] remove unused exception class and outdated todo --- b2/console_tool.py | 19 ------------------- .../+remove_redundant_todo.infrastructure.md | 1 + 2 files changed, 1 insertion(+), 19 deletions(-) create mode 100644 changelog.d/+remove_redundant_todo.infrastructure.md diff --git a/b2/console_tool.py b/b2/console_tool.py index 4568c54ee..ed1020b99 100644 --- a/b2/console_tool.py +++ b/b2/console_tool.py @@ -4056,25 +4056,6 @@ def _setup_logging(cls, args, argv): get_parser = functools.partial(B2.get_parser, for_docs=True) -# TODO: import from b2sdk as soon as we rely on 1.0.0 -class InvalidArgument(B2Error): - """ - Raised when one or more arguments are invalid - """ - - def __init__(self, parameter_name, message): - """ - :param parameter_name: name of the function argument - :param message: brief explanation of misconfiguration - """ - super().__init__() - self.parameter_name = parameter_name - self.message = message - - def __str__(self): - return f"{self.parameter_name} {self.message}" - - def main(): ct = ConsoleTool(b2_api=None, stdout=sys.stdout, stderr=sys.stderr) exit_status = ct.run_command(sys.argv) diff --git a/changelog.d/+remove_redundant_todo.infrastructure.md b/changelog.d/+remove_redundant_todo.infrastructure.md new file mode 100644 index 000000000..0bafbbbe2 --- /dev/null +++ b/changelog.d/+remove_redundant_todo.infrastructure.md @@ -0,0 +1 @@ +Remove unused exception class and outdated todo \ No newline at end of file From 92a26fa58079cf8a5be7ad278240e849a1caa93d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Nowacki?= Date: Thu, 23 Nov 2023 21:41:54 +0100 Subject: [PATCH 2/3] skip draft step in releases --- .github/workflows/cd.yml | 7 +++---- changelog.d/+skip_draft_step_in_releases.infrastructure.md | 1 + 2 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 changelog.d/+skip_draft_step_in_releases.infrastructure.md diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index adafe1f5b..48a109db6 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -6,7 +6,6 @@ on: env: CD: "true" - ACTIONS_STEP_DEBUG: ${{ secrets.ACTIONS_STEP_DEBUG }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PYTHON_DEFAULT_VERSION: "3.11" @@ -41,7 +40,7 @@ jobs: with: name: ${{ steps.build.outputs.version }} body: ${{ steps.read-changelog.outputs.changes }} - draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }} + draft: false prerelease: false files: ${{ steps.build.outputs.asset_path }} - name: Upload the distribution to PyPI @@ -80,7 +79,7 @@ jobs: uses: softprops/action-gh-release@v1 with: name: ${{ needs.deploy.outputs.version }} - draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }} + draft: false prerelease: false files: ${{ steps.sign.outputs.asset_path }} deploy-windows-bundle: @@ -120,6 +119,6 @@ jobs: uses: softprops/action-gh-release@v1 with: name: ${{ needs.deploy.outputs.version }} - draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }} + draft: false prerelease: false files: ${{ steps.sign.outputs.asset_path }} diff --git a/changelog.d/+skip_draft_step_in_releases.infrastructure.md b/changelog.d/+skip_draft_step_in_releases.infrastructure.md new file mode 100644 index 000000000..2a0be7fbd --- /dev/null +++ b/changelog.d/+skip_draft_step_in_releases.infrastructure.md @@ -0,0 +1 @@ +Skip draft step in releases - all successful released are public \ No newline at end of file From 20097cbe2efafea7f3fc6e979049e2dd0526ac05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Nowacki?= <77497496+mpnowacki-reef@users.noreply.github.com> Date: Thu, 23 Nov 2023 22:03:57 +0100 Subject: [PATCH 3/3] Update changelog.d/+skip_draft_step_in_releases.infrastructure.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Maciej Urbański <122983254+mjurbanski-reef@users.noreply.github.com> --- changelog.d/+skip_draft_step_in_releases.infrastructure.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/+skip_draft_step_in_releases.infrastructure.md b/changelog.d/+skip_draft_step_in_releases.infrastructure.md index 2a0be7fbd..641e83278 100644 --- a/changelog.d/+skip_draft_step_in_releases.infrastructure.md +++ b/changelog.d/+skip_draft_step_in_releases.infrastructure.md @@ -1 +1 @@ -Skip draft step in releases - all successful released are public \ No newline at end of file +Skip draft step in releases - all successful releases are public \ No newline at end of file