Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install fails for node 0.8 #107

Closed
fidian opened this issue Feb 4, 2015 · 6 comments
Closed

npm install fails for node 0.8 #107

fidian opened this issue Feb 4, 2015 · 6 comments

Comments

@fidian
Copy link

fidian commented Feb 4, 2015

It appears that version 0.7.3 is using glob ^4.3.5, which node 0.8 does not understand. I have a pull request that's failing its tests (see tests-always-included/pretty-js#13) because of this. It looks like any future commit I add to the repository will also break. Is it possible to use another, similar syntax? eg ~4.3.5 or >4.3.5?

This may be related to issue #96, as though the same issue has cropped up with this newer version.

I don't see version 0.7.3 in this repository, yet it was pushed to npm.

@smikes
Copy link
Collaborator

smikes commented Feb 4, 2015

Node 0.8 is supported but you need a newer npm.

npm install -g npm@latest

@smikes
Copy link
Collaborator

smikes commented Feb 4, 2015

Sorry about the repo inconsistency. 0.7.3 was pushed to my fork, not this repo. Now fixed.

@fidian
Copy link
Author

fidian commented Feb 4, 2015

I don't have a lot of control over Travis. Is upgrading npm like this
normal? I thought that npm shipped with node by default.

Should this issue be taken up with Travis CI instead?
On Feb 4, 2015 5:14 PM, "Sam Mikes" [email protected] wrote:

Node 0.8 is supported but you need a newer npm.

npm install -g npm@latest


Reply to this email directly or view it on GitHub
#107 (comment).

@smikes
Copy link
Collaborator

smikes commented Feb 4, 2015

You can update npm on Travis with a pre install command of the form above. 

I think there's one in jslint 'a Travis.yml actually. 

Normally I would try to make the stock 0.8 npm work but there's been an enormous amount of work on npm since then and it's a reasonably painless upgrade.

On Wed, Feb 4, 2015 at 4:18 PM, Tyler Akins [email protected]
wrote:

I don't have a lot of control over Travis. Is upgrading npm like this
normal? I thought that npm shipped with node by default.
Should this issue be taken up with Travis CI instead?
On Feb 4, 2015 5:14 PM, "Sam Mikes" [email protected] wrote:

Node 0.8 is supported but you need a newer npm.

npm install -g npm@latest


Reply to this email directly or view it on GitHub
#107 (comment).


Reply to this email directly or view it on GitHub:
#107 (comment)

@smikes
Copy link
Collaborator

smikes commented Feb 4, 2015

The nice thing about updating this way is that you no longer have to police your dependencies for ^ vs ~ syntax. (And their dependencies, recursively, until the end of the world).

It does represent pain for people actually running 0.8 in production but I haven't run into any of them yet.

On Wed, Feb 4, 2015 at 4:23 PM, Sam Mikes [email protected] wrote:

You can update npm on Travis with a pre install command of the form above. 
I think there's one in jslint 'a Travis.yml actually. 
Normally I would try to make the stock 0.8 npm work but there's been an enormous amount of work on npm since then and it's a reasonably painless upgrade.
On Wed, Feb 4, 2015 at 4:18 PM, Tyler Akins [email protected]
wrote:

I don't have a lot of control over Travis. Is upgrading npm like this
normal? I thought that npm shipped with node by default.
Should this issue be taken up with Travis CI instead?
On Feb 4, 2015 5:14 PM, "Sam Mikes" [email protected] wrote:

Node 0.8 is supported but you need a newer npm.

npm install -g npm@latest


Reply to this email directly or view it on GitHub
#107 (comment).


Reply to this email directly or view it on GitHub:
#107 (comment)

@fidian
Copy link
Author

fidian commented Feb 5, 2015

Thanks for the tip about the before_install hook. I copied the lines verbatim out of this project's .travis.yml file. I really appreciate the swift feedback.

As for the dependencies for people actually using 0.8 in production, I don't think I'm too fussed about that. jslint was only used for the devDependencies and typically people installing my module won't need to download and use jslint.

@fidian fidian closed this as completed Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants