From d96ace54fdd2fe6d3cbf28dbb15ad4b080ccf04a Mon Sep 17 00:00:00 2001
From: Joe Prosser <joe.prosser@uipath.com>
Date: Wed, 1 Nov 2023 16:01:49 +0000
Subject: [PATCH] feat(commands): transform tag optional on create bucket

---
 CHANGELOG.md                      |  1 +
 cli/src/commands/create/bucket.rs | 12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ba205001..e3ad6a0a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## Unreleased
 - Fix url used for fetching streams
 - Return `is_end_sequence` on stream fetch
+- Make `transform_tag` optional on `create bucket`
 
 ## v0.20.0
 
diff --git a/cli/src/commands/create/bucket.rs b/cli/src/commands/create/bucket.rs
index 89206420..f7f4f8b1 100644
--- a/cli/src/commands/create/bucket.rs
+++ b/cli/src/commands/create/bucket.rs
@@ -1,6 +1,7 @@
 use crate::printer::Printer;
 use anyhow::{Context, Result};
 use log::info;
+use once_cell::sync::Lazy;
 use reinfer_client::{BucketFullName, BucketType, Client, NewBucket, TransformTag};
 use structopt::StructOpt;
 
@@ -21,9 +22,12 @@ pub struct CreateBucketArgs {
     #[structopt(long = "transform-tag")]
     /// Set the transform tag of the new bucket. You will be given this value
     /// by a Re:infer engineer.
-    transform_tag: TransformTag,
+    transform_tag: Option<TransformTag>,
 }
 
+static DEFAULT_TRANSFORM_TAG: Lazy<TransformTag> =
+    Lazy::new(|| TransformTag("generic.0.CONVKER5".to_string()));
+
 pub fn create(client: &Client, args: &CreateBucketArgs, printer: &Printer) -> Result<()> {
     let CreateBucketArgs {
         name,
@@ -32,6 +36,12 @@ pub fn create(client: &Client, args: &CreateBucketArgs, printer: &Printer) -> Re
         transform_tag,
     } = args;
 
+    let transform_tag = &if let Some(transform_tag) = transform_tag {
+        transform_tag.clone()
+    } else {
+        DEFAULT_TRANSFORM_TAG.clone()
+    };
+
     let bucket = client
         .create_bucket(
             name,