From 6bb37c2acbd032ffc3d2f6d07b0e51444b57f654 Mon Sep 17 00:00:00 2001 From: Joe Prosser Date: Tue, 8 Oct 2024 15:36:39 +0100 Subject: [PATCH 1/3] rename label def description -> instruction --- api/src/resources/label_def.rs | 4 ++-- cli/tests/test_datasets.rs | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/api/src/resources/label_def.rs b/api/src/resources/label_def.rs index 478fb2b4..77acf4c4 100644 --- a/api/src/resources/label_def.rs +++ b/api/src/resources/label_def.rs @@ -12,7 +12,7 @@ pub struct LabelDef { pub name: Name, #[serde(default)] - pub description: String, + pub instructions: String, #[serde(default, skip_serializing_if = "Option::is_none")] pub external_id: Option, #[serde(default, skip_serializing_if = "Option::is_none")] @@ -28,7 +28,7 @@ pub struct NewLabelDef { pub name: Name, #[serde(default, skip_serializing_if = "Option::is_none")] - pub description: Option, + pub instructions: Option, #[serde(default, skip_serializing_if = "Option::is_none")] pub external_id: Option, #[serde(default, skip_serializing_if = "Option::is_none")] diff --git a/cli/tests/test_datasets.rs b/cli/tests/test_datasets.rs index 50ce664c..28d75e5a 100644 --- a/cli/tests/test_datasets.rs +++ b/cli/tests/test_datasets.rs @@ -132,7 +132,7 @@ fn test_create_update_dataset_custom() { }, { "name": "foo", - "description": "Long label description", + "instructions": "Long label description", "external_id": "ext id", "title": "Title Me", "pretrained": { @@ -224,7 +224,7 @@ fn test_create_update_dataset_custom() { label_defs: vec![ LabelDef { name: LabelName("bar".to_owned()), - description: "".to_owned(), + instructions: "".to_owned(), external_id: None, pretrained: None, title: "".to_owned(), @@ -232,7 +232,7 @@ fn test_create_update_dataset_custom() { }, LabelDef { name: LabelName("foo".to_owned()), - description: "Long label description".to_owned(), + instructions: "Long label description".to_owned(), external_id: Some("ext id".to_owned()), pretrained: Some(LabelDefPretrained { id: LabelDefPretrainedId("0000000000000001".to_owned()), @@ -250,7 +250,7 @@ fn test_create_update_dataset_custom() { label_defs: vec![ LabelDef { name: LabelName("bar".to_owned()), - description: "".to_owned(), + instructions: "".to_owned(), external_id: None, pretrained: None, title: "".to_owned(), @@ -258,7 +258,7 @@ fn test_create_update_dataset_custom() { }, LabelDef { name: LabelName("foo".to_owned()), - description: "Long label description".to_owned(), + instructions: "Long label description".to_owned(), external_id: Some("ext id".to_owned()), pretrained: Some(LabelDefPretrained { id: LabelDefPretrainedId("0000000000000001".to_owned()), From ec513474c423b018981bd73cca3f881e1c422afc Mon Sep 17 00:00:00 2001 From: Joe Prosser Date: Tue, 8 Oct 2024 15:37:04 +0100 Subject: [PATCH 2/3] add ixp dataset flag --- api/src/resources/dataset.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/api/src/resources/dataset.rs b/api/src/resources/dataset.rs index 86154a31..a3c646f9 100644 --- a/api/src/resources/dataset.rs +++ b/api/src/resources/dataset.rs @@ -27,6 +27,7 @@ pub enum DatasetFlag { ExternalMoonLlm, Qos, ZeroShotLabels, + Ixp, } #[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)] From ddea31735e47a748bdae0aaae63e4cd70c1fd4c3 Mon Sep 17 00:00:00 2001 From: Joe Prosser Date: Tue, 8 Oct 2024 15:38:20 +0100 Subject: [PATCH 3/3] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 554fb0a9..196ac824 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ # Unreleased - Round trip `field_id` +- Add `ixp` dataset flag +- rename label def description to instructions # v0.33.1 - Fix selection index issue on custom label trend reports