Add support for C39 in templates #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 5, 2020 13:17
This commit adds extra template handlers: BCC39 and BCI25. First generetes BCC39 barcode. Second one is added to keep API consistency and call BC under the hood
|
if its possible for you to pr this against https://github.com/alexanderankin/pyfpdf/issues then i may release it as i am maintaining fpdf2 |
|
That's nice how you added documentation on I second @alexanderankin suggestion: could you please submit this PR against his fork (which is fpdf2 on Pypi) and we'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for barcode following C39 in templates (
BCC39). It also extends an interface to be consistent with barcodes in template -I25(BCI25) is explicitly added which call the same function asBC.BCis not changed to provide backwards compatibility.This pull request also introduces a change in
code39method fromFPDFclass (responsible for barcode generation following C39 standard). Since now, it is not required to escape text on your own (adding '*' at the beginning and at the end of the string). This change does not provide backwards compatibility.