Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

Revanced root building not working with Android device method #213

Closed
binoysankar opened this issue Aug 10, 2022 · 11 comments
Closed

Revanced root building not working with Android device method #213

binoysankar opened this issue Aug 10, 2022 · 11 comments

Comments

@binoysankar
Copy link

binoysankar commented Aug 10, 2022

Edit by @reisxd:

This issue was closed because @binoysankar fixed this issue thanks to #213 (comment)

Old issue:

Describe the bug:

When trying to build revanced apk/file in Android phone (rooted) I am getting the below error (PFA Screenshot).
During the building process I gave Termux the root access as well. With Microg option the build is successful.
Screenshot_20220810-175327_Chrome
Screenshot_20220810-175321_Termux

@shrihankp
Copy link
Collaborator

This is a known issue. I haven't got the time to test and fix it (I do have a rooted device).

@binoysankar
Copy link
Author

This is a known issue. I haven't got the time to test and fix it (I do have a rooted device).

Sure. Np. Thanks for the update. I was looking for the rooted varient and saw this error while building.
Eagerly waiting for the fix some day :)

@reisxd
Copy link
Owner

reisxd commented Aug 12, 2022

Can you try clearing Termuxs cache and if it still doesn't work, clearing data and installing Builder again?

@munchycool
Copy link

Hello @reisxd ..long time no see ;)

I tried on a fresh brand new install of Miui on poco x3 pro and I think issue is arising since on some dynamic partition devices with super you cannot mount system as rw even after rooting ...

you first need to do this
https://forum.xda-developers.com/t/closed-script-android-10-universal-mount-systemrw-superrw-featuring-makerw-read-write.4247311/

would it be a better idea to make a magisk module instead?

@reisxd
Copy link
Owner

reisxd commented Aug 13, 2022

Hello @reisxd ..long time no see ;)

I tried on a fresh brand new install of Miui on poco x3 pro and I think issue is arising since on some dynamic partition devices with super you cannot mount system as rw even after rooting ...

you first need to do this
https://forum.xda-developers.com/t/closed-script-android-10-universal-mount-systemrw-superrw-featuring-makerw-read-write.4247311/

would it be a better idea to make a magisk module instead?

Sadly, I don't know how to write magisk module instead, and well... I litterally didn't understand anything you said because I never rooted my devices. 😅

@munchycool
Copy link

can we add a timeout feature? lets say its stuck at trying to mount revanced for 60 seconds, it just puts the rooted apk in the folder and lets us know that its unable to mount system as rw, apk placed here ....try replacing manually?

@Alprnn357
Copy link

I have patched yt and yt music for my rooted device and works flawlessly on mine. Also i used the same android method.
20220817_181230

@reisxd reisxd mentioned this issue Aug 19, 2022
@kevinross
Copy link

kevinross commented Aug 19, 2022

Can reproduce on my device (rooted OP7 running oxygen os 11), same /etc/fstab issue as well.

ETA: I reran the script with set -x added, I think I know why: I uninstalled all updates, so when it tries to grep for base it returns an empty string. Since there's no /etc for an fstab to exist in and the last arg to mount is an empty string... fail.

@ghost
Copy link

ghost commented Aug 20, 2022

It works fine, you just need to install the stock youtube app first and then run the patch. I was having the same issue and solved it this way. Make sure both stock and revanced youtube app versions match.

@binoysankar
Copy link
Author

It works fine, you just need to install the stock youtube app first and then run the patch. I was having the same issue and solved it this way. Make sure both stock and revanced youtube app versions match.

This resolved my issue. Thank you.

@reisxd
Copy link
Owner

reisxd commented Aug 20, 2022

It works fine, you just need to install the stock youtube app first and then run the patch. I was having the same issue and solved it this way. Make sure both stock and revanced youtube app versions match.

This resolved my issue. Thank you.

Then I'm closing and pinning this issue for future reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants