-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The attribute standard_relationship should be a collection #6
Conversation
@andrew2net can you add the spec fixture for the failure so we don't encounter it again? You can just copy that file from rawbib. Thanks. |
@ronaldtse I can add fixtures. But we need to create another test for this cases because lutaml-model creates collection automatically even there is no
With the option we always get an array and can handle it same and simplify code in the relaton-ieee. |
@andrew2net I think this is a problem in lutaml-model for being implicit or "not caring" the actual model. This just means that I think when |
@ronaldtse agree. If lutaml-model caries the actual model then the round-test will fall without collection option when an attribute is actually collection. So we won't need addition tests in this gem. |
Agree with @andrew2net , I've posted the issue at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrew2net thank you, please feel free to merge!
fixes #5