added test dispose subscription and change return in loadquery subscr…

…ibe function
relay-tools · Sep 24, 2020 · ea45b53 · ea45b53
1 parent 4be49a4
commit ea45b53
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/__tests__/usePreloadQuery-test.tsx b/__tests__/usePreloadQuery-test.tsx
@@ -798,5 +798,16 @@ describe('usePreloadQuery', () => {
                 },
             });
         });
+
+        it('dispose subscription', () => {
+            const callback = jest.fn(() => {});
+            const dispose = prefetched.subscribe(callback);
+            dispose();
+            prefetched.next(environment, params, { id: '4' });
+            dataSource.next(response);
+            dataSource.complete();
+            TestRenderer.act(() => jest.runAllImmediates());
+            expect(callback).not.toBeCalled();
+        });
     });
 });
diff --git a/src/loadQuery.ts b/src/loadQuery.ts
@@ -81,7 +81,9 @@ const internalLoadQuery = <TOperationType extends OperationType = OperationType>
 
     const subscribe = (callback: (value) => any): (() => void) => {
         listener = callback;
-        return dispose;
+        return (): void => {
+            listener = null;
+        };
     };
     return {
         next,