Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to new parcel notifications in PoWeb via Redis PubSub #929

Closed
3 tasks done
gnarea opened this issue Dec 7, 2022 · 1 comment · Fixed by #1069
Closed
3 tasks done

Subscribe to new parcel notifications in PoWeb via Redis PubSub #929

gnarea opened this issue Dec 7, 2022 · 1 comment · Fixed by #1069
Labels
enhancement New feature or request PDC Parcel Delivery Connection released

Comments

@gnarea
Copy link
Member

gnarea commented Dec 7, 2022

Describe the problem

We currently use NATS Streaming in PoWeb's collectParcels method to be notified about new parcels, but we're deprecating NATS Streaming in production (relaycorp/cloud-gateway#84).

Describe the solution you'd like

Replace the NATS Streaming-based non-durable subscription with one based on Redis PubSub, using node-redis or ioredis.

  • Integrate Redis in development chart.
  • Update publisher.
  • Update subscriber.

Describe alternatives you've considered

Using GCP PubSub in Relaycorp-managed, production instances, whilst retaining NATS Streaming support (see #760). However, (1) we need Redis as a backing service anyway (see #19) and (2) making the underlying backend pluggable will increase complexity drastically.

Additional context

This isn't the only use of NATS Streaming. See #929

@gnarea gnarea added enhancement New feature or request PDC Parcel Delivery Connection labels Dec 7, 2022
@gnarea gnarea changed the title PoWeb: Subscribe to new parcel notifications via Redis PubSub Subscribe to new parcel notifications in PoWeb via Redis PubSub Dec 9, 2022
@gnarea gnarea moved this from Todo to In Progress in Serverless public gateways Oct 9, 2023
@kodiakhq kodiakhq bot closed this as completed in e090611 Oct 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Serverless public gateways Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PDC Parcel Delivery Connection released
Projects
1 participant