Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Denial of Existence records (NSEC and NSEC3) #17

Open
gnarea opened this issue Sep 16, 2022 · 0 comments
Open

Add support for Denial of Existence records (NSEC and NSEC3) #17

gnarea opened this issue Sep 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@gnarea
Copy link
Member

gnarea commented Sep 16, 2022

We don't need DoE records in Vera, so we're not implementing them. However, we'd welcome PRs to support them.

Note that this missing feature does not represent a security vulnerability because DNSSEC verification will still fail -- it'll just throw an error instead of returning a SecurityStatus value.

High-level design

These are the main changes we have to make as of November 2022:

  • Message: Add support for Authority answers.
  • ZoneSigner: Add two methods, to be used in the tests: generateNsec() and generateNsec3().
  • Zone.initChild(): Change return type from VerificationResult<Zone> to VerificationResult<Zone | null>, and use null as a successful result when the DS response for the child zone denies the existence of such a record.
  • UnverifiedChain.verify(): Change return type from VerificationResult<RRSet> to VerificationResult<RRSet | null>, and use null as a successful result when the apex zone denies the existence of such an RRset.
  • Update README to remove comments about not supporting DoE records.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant