Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All ECDH keys are silently created using P-256 #53

Open
gnarea opened this issue Feb 11, 2020 · 0 comments
Open

All ECDH keys are silently created using P-256 #53

gnarea opened this issue Feb 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@gnarea
Copy link
Member

gnarea commented Feb 11, 2020

I think this is a bug in PKI.js or, perhaps more likely, node-webcrypto-ossl. This can be reproduced by calling generateECDHKeyPair with a curve other than P-256.

This isn't a major issue because support for P-256 is required and support for the other curves is just recommended.

Once this is fixed, reinstate this commented-out test:

https://github.com/relaycorp/relaydev/blob/master/functional_tests/test-key-genecdh.sh#L5-L8

@gnarea gnarea added the bug Something isn't working label Feb 11, 2020
gnarea added a commit to relaycorp/relaydev that referenced this issue Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant