Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroot exclusion (configuration per-package) doesn't work #3528

Open
praiskup opened this issue Nov 23, 2024 · 7 comments · May be fixed by release-engineering/dist-git#79
Open

Chroot exclusion (configuration per-package) doesn't work #3528

praiskup opened this issue Nov 23, 2024 · 7 comments · May be fixed by release-engineering/dist-git#79
Assignees
Labels

Comments

@praiskup
Copy link
Member

https://copr.fedorainfracloud.org/coprs/g/copr/copr-dev/build/8300602/

It fails:
Screenshot_20241123_190227

Even though we have configured the project to skip epel-7* chroots:

Screenshot_20241123_190319

@praiskup
Copy link
Member Author

Nb. this build was triggered by this Packit configuration 🤷

@nikromen nikromen added the bug label Nov 27, 2024
@nikromen nikromen moved this from Needs triage to In 3 months in CPT Kanban Nov 27, 2024
@nikromen
Copy link
Member

provide test case for this please 🙏

@nikromen nikromen moved this from In 3 months to In Progress in CPT Kanban Jan 21, 2025
@praiskup
Copy link
Member Author

Direct SRPM upload isn't affected: https://copr.fedorainfracloud.org/coprs/g/copr/copr-dev/build/8583971/

@praiskup
Copy link
Member Author

Tito build isn't affected either: https://copr.fedorainfracloud.org/coprs/g/copr/copr-dev/build/8583976/

@praiskup
Copy link
Member Author

@mfocko considering we use https://github.com/release-engineering/dist-git/blob/main/.packit.yaml#L40-L44, do you think Packit explicitly selects also epel-7 (if enabled in given copr)?

@praiskup
Copy link
Member Author

The latest build: release-engineering/dist-git@9f0bfee
This appears to be a problem in Packit. First, the .packit.yaml config doesn't seem to be respected, then the chroot_denylist is also ignored.

@mfocko
Copy link
Contributor

mfocko commented Jan 30, 2025

@mfocko considering we use https://github.com/release-engineering/dist-git/blob/main/.packit.yaml#L40-L44, do you think Packit explicitly selects also epel-7 (if enabled in given copr)?

Could you try dropping the metadata section? I can't imagine what the YAML produces off top of my head 👀 If the metadata subdictionary from the trigger: commit overwrites the one from the pull_request we take the targets from the Copr project itself then…

The issue with differentiating the chroots based on the packages (as you've shown in the screenshot above) would not be an easy task to resolve I'm afraid…

Edit: yq seems to agree:

"jobs": [
    {
      "job": "copr_build",
      "packages": [
        "dist-git",
        "dist-git-client"
      ],
      "trigger": "pull_request",
      "metadata": {
        "targets": [
          "fedora-all-x86_64",
          "epel-8-x86_64",
          "epel-9-x86_64",
          "epel-10-x86_64"
        ]
      }
    },
    {
      "job": "copr_build",
      "packages": [
        "dist-git",
        "dist-git-client"
      ],
      "trigger": "commit",
      "metadata": {
        "owner": "@copr",
        "project": "copr-dev",
        "branch": "main"
      }
    }
  ]

mfocko added a commit to mfocko/dist-git that referenced this issue Jan 30, 2025
`metadata` sections are deprecated for a long time, also in this case it
breaks the YAML expansion which replaces whole `metadata` section instead
of merging it together.

Fixes fedora-copr/copr#3528

Signed-off-by: Matej Focko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants