Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure AFLAGS are always accessible by parent across CMake reruns. #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make sure AFLAGS are always accessible by parent across CMake reruns. #208

wants to merge 1 commit into from

Conversation

AmineKhaldi
Copy link

No description provided.

@dfaranha
Copy link
Contributor

Hi! This does not have to be cached because ARCH is already cached... or am I missing something?

@AmineKhaldi
Copy link
Author

I noticed this issue while working on the test scenarios we discussed: https://pastebin.com/DR6PnDwY

@dfaranha
Copy link
Contributor

I get it, but I don't see how the current behavior creates problems. On the other hand, caching one more variable takes space in the ccmake interface.

@AmineKhaldi
Copy link
Author

Re. behavior, when CMake reruns for any reason, the -m32/-m64 flags are gone from the compiler invocation according to my tests. Is that intentional/acceptable?
Re. the cache value, we can make it INTERNAL if that's more adequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmineKhaldi @dfaranha