Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cope better with EDITOR not being defined #6

Open
dchambers opened this issue Aug 17, 2015 · 0 comments
Open

Cope better with EDITOR not being defined #6

dchambers opened this issue Aug 17, 2015 · 0 comments

Comments

@dchambers
Copy link

There are a couple of ways this could be achieved:

  1. Fail-fast with a nice error message if EDITOR has not been defined.
  2. Ask the developer to enter the path to their editor in lieu of EDITOR not being defined.

Ideally, my preference would be for option 2, as I plan to use publish-release within the postpublish hook of all our modules, and this would allow developers who run npm publish to still have things work, rather than requiring them to define EDITOR, then re-run npm run postpublish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants