Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contacts] Use correct ontology URI and schema for vCard #56

Open
raucao opened this issue Jun 1, 2014 · 18 comments
Open

[contacts] Use correct ontology URI and schema for vCard #56

raucao opened this issue Jun 1, 2014 · 18 comments

Comments

@raucao
Copy link
Member

raucao commented Jun 1, 2014

http://www.w3.org/TR/2014/NOTE-vcard-rdf-20140522

@michielbdejong
Copy link
Member

good point. in http://www.w3.org/TR/2014/NOTE-vcard-rdf-20140522/#Overview it is stated that the correct URI, both for rdf and for json-ld, is "http://www.w3.org/2006/vcard/ns#"

@raucao
Copy link
Member Author

raucao commented Jun 1, 2014

There's a JSON-LD example as well.

@michielbdejong
Copy link
Member

ok, I'll update the module so that it uses that instead of http://remotestorage.io/modules/code/files/contacts-js.html#contacts/contact

@raucao
Copy link
Member Author

raucao commented Jun 3, 2014

This is still missing a whole lot of fields, and most importantly, still doesn't specificy the actual schema, including format information for stuff like URLs etc, which we can all define.

@raucao raucao reopened this Jun 3, 2014
@michielbdejong
Copy link
Member

good point, that wasn't clear. fixed now.

I updated the schema definition so that it's clear that any field that exists in the vcard spec is allowed, and the schema we give here is non-normative. they're just the fields we want to check at runtime.

@raucao
Copy link
Member Author

raucao commented Jun 3, 2014

That's not solving...

This is still missing a whole lot of fields, and most importantly, still doesn't specify the actual schema, including format information for stuff like URLs etc, which we can all define.

If you don't want to do it, please leave it open for me or someone else to complete. We can define all known fields, so that developers don't have to do extend the module for their app in order to have validation etc.

@raucao raucao reopened this Jun 3, 2014
@michielbdejong
Copy link
Member

sure, you can add more fields if you think you or someone else will use them

@raucao
Copy link
Member Author

raucao commented Jun 3, 2014

That's a nonsensical "if". I'll add them for other reasons, namely the ones I already wrote down.

@elf-pavlik
Copy link
Member

do you use JSON-LD @context in data you store?

$  curl http://www.w3.org/2006/vcard/ns -H "Accept: application/ld+json"

@elf-pavlik
Copy link
Member

i wonder if your schema and code handles properly cases like multiple values:

{
  hasEmail: [
    "[email protected]",
    "[email protected]"
  ]
}

http://www.w3.org/TR/json-ld/#sets-and-lists

as well as multiple languages:

{
  fn: {
    en: "Ismail",
    ar: "إسماعيل"
  }
}

http://www.w3.org/TR/json-ld/#string-internationalization

@raucao
Copy link
Member Author

raucao commented Jun 3, 2014

do you use JSON-LD @context in data you store?

Yes.

i wonder if your schema and code handles properly cases like multiple values:

We can define that in the JSON Schema object. JSON schema is extensible in theory, but you can also just amend the schema in the module. We even have an extend method in modules for merging objects like schemas. The schema we define should account for all standard use cases, though, so that people don't have to muck around in the module.

@elf-pavlik
Copy link
Member

thx @skddc! I guess I move further conversation to http://community.remotestorage.io/ :)

@almereyda
Copy link
Member

Completely OT, but hey: Well, @elf-pavlik, you didn't check that page in a while, didn't you? The Discourse service died some days/weeks ago. I wonder if it would make sense, @skddc, if we joined forces and I'd put the last backup you have within my new Discourse farm at Ecobytes. ?

@elf-pavlik
Copy link
Member

👍 AFAIK you guys live in the same town, just do a small hack party and make it happen 😃

@raucao
Copy link
Member Author

raucao commented Jun 4, 2014

We're still waiting for the data. It's not because we're lazy.

@almereyda
Copy link
Member

Good luck with the backup.

On 4 June 2014 11:45, Sebastian Kippe [email protected] wrote:

We're still waiting for the data. It's not because we're lazy.


Reply to this email directly or view it on GitHub
#56 (comment)
.

@elf-pavlik
Copy link
Member

this should help: https://github.com/lanthaler/vCardOntology
from one of JSON-LD spec authors!

@raucao
Copy link
Member Author

raucao commented Dec 2, 2014

Nice, thanks!

That would mean we'd have to introduce support for maps/objects as @context. Looks like our implementation still needs work to support using all of JSON-LD.

@raucao raucao added the ready label Mar 19, 2016
@raucao raucao removed their assignment May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants