Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Type Definitions #11

Open
ebi-igweze opened this issue Apr 10, 2017 · 3 comments
Open

No Type Definitions #11

ebi-igweze opened this issue Apr 10, 2017 · 3 comments

Comments

@ebi-igweze
Copy link

I've searched for type definitions both on npm and tsd but can't find. Are there any type definitions for vanilla-ui-router?

@reneviering
Copy link
Owner

Hey,
thanks for trying vanilla-ui-router. This project is written in pure vanilla ES6 JavaScript to stay as simple as possible. So there are no type definitions in JavaScript. Feel free to fork this project.

René

@reneviering
Copy link
Owner

@nicolaisueper added some type definitions in his pull request https://github.com/micromata/vanilla-ui-router/pull/12/files. To separate the vanilla-ui-router ES6 code base from the type definitions it would be a good fit to put them to DefinitlyTyped.

I'm not a typescript pro, so pull requests are very welcome. Otherwise maybe I find the time to add it in the near future.

@nicolaisueper
Copy link
Contributor

I'll do this until sunday ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants