BUG with Maven replacement

[ylazakovich]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

gitlab, github

Please tell us more about your question or problem

Replacement doesn't work as expected

Firstly,

I thought that renovate will replace it
FROM: org.hibernate-5.6.15.Final
TO: org.hibernate.orm-6.0.0.Final

But actual behavior is:
FROM: org.hibernate-5.6.15.Final
TO: org.hibernate-6.5.5.Final

• in this case he doesn't make replace
• he does it to the latest version

I suspect that it happens
due that there are 2 same versions on 2 different places

Logs (if relevant)

Extra info about how description of MR has been changed

[ylazakovich]

Also would like to enable replacement feature for gradle projects

• Currently renovate returns info about that Gradle doesn't support that yet

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[ylazakovich]

https://github.com/ylazakovich/reproduction-33933

[github-actions[bot]]

Hi there,

A maintainer wants you to find and share a specific log message (packageFiles with updates) from your repository or environment.

If you self-host Renovate: make sure you run Renovate with LOG_LEVEL=debug to get the debug log messages! Next, open the debug-level logs and search for packageFiles with updates. This text marks the start of a structured log message that shows every package file, dependency, and update that Renovate found.

Find the relevant dependency/dependencies in the log message, and copy/paste those parts into this discussion. If you do not know which bits we need, you can copy/paste the full log message.

Read the Renovate docs, Troubleshooting to learn more about getting the docs, and getting the correct type of logs.

Thanks, the Renovate team

[ylazakovich]

https://developer.mend.io/github/ylazakovich/reproduction-33933/-/job/177f843f-2dc8-4982-ace2-2a0b7e828002

[ylazakovich]

I see the error in logs

[ylazakovich]

ylazakovich_reproduction-33933_2025-01-30_12-14_177f843f-2dc8-4982-ace2-2a0b7e828002.log

[rarkins]

Is this part expected?

               {
                  "datasource":"maven",
                  "depName":"org.hibernate:hibernate-core",
                  "currentValue":"5.6.15.Final",
                  "fileReplacePosition":418,
                  "registryUrls":[
                     "https://repo.maven.apache.org/maven2"
                  ],
                  "depType":"compile",
                  "sharedVariableName":"hibernate.version",
                  "updates":[
                     {
                        "bucket":"major",
                        "newVersion":"6.6.5.Final",
                        "newValue":"6.6.5.Final",
                        "releaseTimestamp":"2025-01-19T00:14:05.000Z",
                        "newVersionAgeInDays":11,
                        "newMajor":6,
                        "newMinor":6,
                        "newPatch":5,
                        "updateType":"major",
                        "branchName":"renovate/major-hibernate.version"
                     },
                     {
                        "updateType":"replacement",
                        "newName":"org.hibernate.orm:hibernate-core",
                        "newValue":"6.6.5.Final",
                        "branchName":"renovate/hibernate.version"
                     }
                  ],
                  "packageName":"org.hibernate:hibernate-core",
                  "versioning":"maven",

You expect this:

I thought that renovate will replace it
FROM: org.hibernate-5.6.15.Final
TO: org.hibernate.orm-6.0.0.Final

But actual behavior is:
FROM: org.hibernate-5.6.15.Final
TO: org.hibernate-6.5.5.Final

It seems like the existence of the upgrade is to be expected. The presence of a replacement does not block any other updates. But you are expecting 6.0.0 specifically. Where (in source code or docs) does that expectation come from?

[ylazakovich]

For me there is unexpected behaviour

I couldn’t find any explicit documentation describing this behavior, but based on the message in the PR:

This is a special PR that replaces … with the community suggested minimal stable replacement version.

From my perspective, I expected this process to work in two steps:
1. The first step should update the dependency to the first minimal major stable version in the new repository.
2. The second step should then handle further updates to the next available versions.

Since the update went straight to the latest stable version instead, it seems like this assumption wasn’t correct.

[rarkins]

You should expect 2 PRs for your reproduction and not 1. The PR you see is the first expected one. It's an upgrade PR and not instead of the replacement.

Your expectations about the versions are a second matter. I'd like to know what those expectations are based on (links, documentation). You presumably didn't make up the version number..