skipping PR creation after stabilityDays

[koba04]

Renovate doesn't create PRs because of Branch is 265 hours old - skipping PR creation.
But the branch is enough old to be created a PR. Why does Renovate skip PR creation?

This is one of the branches that a PR isn't created.
https://github.com/kintone/js-sdk/tree/renovate/patch-babel-monorepo.

The branch is very old and stabilityDays has been elapsed, which is 3days from the setting.
https://github.com/cybozu/renovate-config/blob/master/renovate.json#L16

In this if block, I guess config.stabilityStatus !== BranchStatus.yellow becomes true because the following condition (elapsedHours < config.prNotPendingHours) would be false because it's an old branch.

renovate/lib/workers/pr/index.ts

Lines 219 to 228 in 746d170

	if (
	!dependencyDashboardCheck &&
	(config.stabilityStatus !== BranchStatus.yellow ||
	elapsedHours < config.prNotPendingHours)
	) {
	logger.debug(
	`Branch is ${elapsedHours} hours old - skipping PR creation`
	);
	return { prResult: PrResult.AwaitingNotPending };
	}

I guess config.stabilityStatus is green, but I'm not sure what it means.

The status of the branch is yellow because this branch was created before we run GitHub Actions for branches Renovate creates. Previously we only run GitHub Actions for pull requests rather than branches, so branches are always in the pending status until a PR has been created. This has been fixed in kintone/js-sdk#608

What should I do for Renovate creates a PR for the branch?

Here is the our renovate.json

https://github.com/cybozu/renovate-config/blob/master/renovate.json

The following is a log for one of our packages.

DEBUG: processBranch with 1 upgrades(branch="renovate/patch-babel-monorepo")
DEBUG: Setting current branch to master(branch="renovate/patch-babel-monorepo")
DEBUG: latest commit(branch="renovate/patch-babel-monorepo")
{
  "branchName": "master",
  "latestCommitDate": "2021-01-19T16:29:02+09:00"
}
DEBUG: getBranchPr(renovate/patch-babel-monorepo)(branch="renovate/patch-babel-monorepo")
DEBUG: findPr(renovate/patch-babel-monorepo, undefined, open)(branch="renovate/patch-babel-monorepo")
DEBUG: branchExists=true(branch="renovate/patch-babel-monorepo")
DEBUG: Branch has 1 upgrade(s)(branch="renovate/patch-babel-monorepo")
DEBUG: recreateClosed is false(branch="renovate/patch-babel-monorepo")
DEBUG: findPr(renovate/patch-babel-monorepo, chore(deps): update dependency @babel/preset-env to ^7.12.11, !open)(branch="renovate/patch-babel-monorepo")
DEBUG: prAlreadyExisted=false(branch="renovate/patch-babel-monorepo")
DEBUG: Checking if PR has been edited(branch="renovate/patch-babel-monorepo")
DEBUG: Checking schedule(after 9pm,before 9am, Asia/Tokyo)(branch="renovate/patch-babel-monorepo")
DEBUG: Found timezone(branch="renovate/patch-babel-monorepo")
{
  "timezone": "Asia/Tokyo"
}
DEBUG: Adjusting now for timezone(branch="renovate/patch-babel-monorepo")
DEBUG: Checking 2 schedule(s)(branch="renovate/patch-babel-monorepo")
DEBUG: Checking schedule "after 9pm"(branch="renovate/patch-babel-monorepo")
{
  "parsedSchedule": {
    "schedules": [
      {
        "t_a": [
          75600
        ]
      }
    ],
    "exceptions": [],
    "error": -1
  }
}
DEBUG: Matches schedule after 9pm(branch="renovate/patch-babel-monorepo")
DEBUG: Branch already exists(branch="renovate/patch-babel-monorepo")
DEBUG: getBranchPr(renovate/patch-babel-monorepo)(branch="renovate/patch-babel-monorepo")
DEBUG: findPr(renovate/patch-babel-monorepo, undefined, open)(branch="renovate/patch-babel-monorepo")
DEBUG: Found branch protection(branch="renovate/patch-babel-monorepo")
DEBUG: Branch does not need rebasing(branch="renovate/patch-babel-monorepo")
DEBUG: Using reuseExistingBranch: true(branch="renovate/patch-babel-monorepo")
DEBUG: manager.getUpdatedPackageFiles()(branch="renovate/patch-babel-monorepo")
{
  "reuseExistingBranch": true,
  "branchName": "renovate/patch-babel-monorepo"
}
DEBUG: npm.updateDependency(): devDependencies.@babel/preset-env = ^7.12.11(branch="renovate/patch-babel-monorepo")
DEBUG: No package files need updating(branch="renovate/patch-babel-monorepo")
DEBUG: Getting updated lock files(branch="renovate/patch-babel-monorepo")
DEBUG: lock file dirs(branch="renovate/patch-babel-monorepo")
{
  "dirs": {
    "yarnLockDirs": [],
    "npmLockDirs": [],
    "pnpmShrinkwrapDirs": [],
    "lernaDirs": []
  }
}
DEBUG: Writing package.json files(branch="renovate/patch-babel-monorepo")
{
  "packageFiles": [
    "examples/rest-api-client-demo/package.json",
    "package.json",
    "packages/create-plugin/package.json",
    "packages/customize-uploader/package.json",
    "packages/dts-gen/package.json",
    "packages/plugin-manifest-validator/package.json",
    "packages/plugin-packer/package.json",
    "packages/plugin-uploader/package.json",
    "packages/profile-loader/package.json",
    "packages/rest-api-client/package.json",
    "packages/webpack-plugin-kintone-plugin/package.json"
  ]
}
DEBUG: Writing any updated package files(branch="renovate/patch-babel-monorepo")
DEBUG: No updated lock files in branch(branch="renovate/patch-babel-monorepo")
DEBUG: No files to commit(branch="renovate/patch-babel-monorepo")
DEBUG: Checking if we can automerge branch(branch="renovate/patch-babel-monorepo")
DEBUG: mergeStatus=no automerge(branch="renovate/patch-babel-monorepo")
DEBUG: Ensuring PR(branch="renovate/patch-babel-monorepo")
DEBUG: There are 0 errors and 0 warnings(branch="renovate/patch-babel-monorepo")
DEBUG: getBranchPr(renovate/patch-babel-monorepo)(branch="renovate/patch-babel-monorepo")
DEBUG: findPr(renovate/patch-babel-monorepo, undefined, open)(branch="renovate/patch-babel-monorepo")
DEBUG: Checking branch combined status(branch="renovate/patch-babel-monorepo")
DEBUG: getBranchStatus(renovate/patch-babel-monorepo)(branch="renovate/patch-babel-monorepo")
DEBUG: branch status check result(branch="renovate/patch-babel-monorepo")
{
  "state": "pending",
  "statuses": []
}
DEBUG: No check runs found(branch="renovate/patch-babel-monorepo")
{
  "result": {
    "total_count": 0,
    "check_runs": []
  }
}
DEBUG: getBranchStatus() result(branch="renovate/patch-babel-monorepo")
{
  "branchStatus": "yellow",
  "branchName": "renovate/patch-babel-monorepo"
}
DEBUG: Branch status is "yellow" - checking timeout(branch="renovate/patch-babel-monorepo")
DEBUG: Branch is 265 hours old - skipping PR creation(branch="renovate/patch-babel-monorepo")

[viceice]

enable dependencyDashboard and use the checkbox there to force pr creation

[koba04]

@viceice Thank you for your help.
Here is the latest log.
https://gist.github.com/koba04/af69bf26d3c747d320f5d13bc7433c38

[viceice]

@rarkins I don't know why it is returning here

renovate/lib/workers/pr/index.ts

Lines 219 to 228 in 746d170

	if (
	!dependencyDashboardCheck &&
	(config.stabilityStatus !== BranchStatus.yellow ||
	elapsedHours < config.prNotPendingHours)
	) {
	logger.debug(
	`Branch is ${elapsedHours} hours old - skipping PR creation`
	);
	return { prResult: PrResult.AwaitingNotPending };
	}

[rarkins]

Isn't the dashboard checked?

[koba04]

@rarkins Do you mean about a dependency dashboard? As I mentioned at #8357 (reply in thread), the PR for a dependency dashboard isn't created yet.

[rarkins]

@viceice Here's the nested logic to get there:

config.prCreation === 'not-pending' &&
!existingPr &&
(await getBranchStatus()) === BranchStatus.yellow &&
(config.stabilityStatus !== BranchStatus.yellow || elapsedHours < config.prNotPendingHours)

Should that last !== be === instead?