Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FROM scratch is a special case and shouldn't cause an error #145

Open
iggy opened this issue Jun 20, 2020 · 3 comments
Open

FROM scratch is a special case and shouldn't cause an error #145

iggy opened this issue Jun 20, 2020 · 3 comments

Comments

@iggy
Copy link

iggy commented Jun 20, 2020

FROM scratch is a special case in docker. It doesn't have any tags and in the build tooling it's a special case to not use an underlying image layer. This tool shouldn't error on a FROM line with scratch.

@marccampbell
Copy link
Member

@iggy thanks for the report. I’ve added an integration test and am not able to reproduce this. Are you able to provide a Dockerfile that has this error?

@iggy
Copy link
Author

iggy commented Aug 12, 2020

I'm using dockerfilelint as part of GitHub's super-linter. Here is a link to it failing as part of that:

https://github.com/iggy/scurvy/runs/940683789?check_suite_focus=true#step:4:194

The line it's referencing:

https://github.com/iggy/scurvy/blob/master/Dockerfile#L74

@marccampbell
Copy link
Member

Thanks @iggy

I added PR #154 which does address and make these pass. I’ll get it reviewed in tomorrow and a new version released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants