-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for GitLab CI/CD. #24
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitLab seems unhappy with the .yaml
expression. When I changed it to .yml
it was happy.
@crdant we're now going to be putting these in https://github.com/replicatedhq/platform-examples right? |
You're absolutely right. It can be changed in the GitLab settings, but indeed to remove the confusion it's better to rename it to a default value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be moved to platform-examples same as we've done with the github workflows. See #26 which is removing the examples from this repo.
Is CD something we want to make sure we encourage with every repo? If it is I wonder if it's an example or it's something to include in the starter. I have arguments in my mind in favor of both approaches:
|
That's a good question, I was using the recommendation "You shouldn't have to remove anything from your starter repo". Using that filter, GitLab and GitHub CI wouldn't belong here since you need to remove at least one of them. Expanding to other CI options will only make that grow. I could see the argument since the repo is on Github we setup the github workflows in the repo and you don't need to remove them. Then we have the same things you mention above, having to maintain them and possibly customize them with users. I don't suppose there's a perfect answer either way. I think I lean toward just not putting any CI in the repo, and give examples that people can drop in and use. They have to configure their environment variables to make them work anyway so it's never completely hands off. |
Closes #21