Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Namespace not enforced #991

Open
tomaszkiewicz opened this issue Jun 24, 2019 · 0 comments
Open

Namespace not enforced #991

tomaszkiewicz opened this issue Jun 24, 2019 · 0 comments

Comments

@tomaszkiewicz
Copy link

Expected behavior

On the 2nd step, when I set values for helm chart there's "Helm Namespace" field available.
When I put a desired namespace there I expect that on rendered.yaml file all namespace-scoped resources will be deployed to that namespace.

Actual behavior

When I put some namespace there it's not enforced by Ship, probably it's due to this issue in helm:
helm/helm#3553

Information

  • Ship version:
    {
    "version": "0.44.0",
    "git": "d27319b",
    "buildTime": "2019-05-20T18:49:30Z",
    "dependencies": {
    "helm": "v2.13.0",
    "kustomize": "v2.0.3",
    "terraform": "v0.11.14"
    }
    }
  • Docker version: not important
  • Command line run: ship edit / ship init

Steps to reproduce the behavior

  1. ship init any chart that doesn't offer namespace customization by itself (e.g. kube2iam)
  2. put custom namespace on second step
  3. complete a wizard to get rendered.yaml file
  4. inspect the file

Suggested solutions / workarounds

As ship uses kustomize in the next step the simplest solution is to just propagate a namespace specified in 2nd step into kustomization.yaml used for final generation of manifest.

Alternative approach would be to allow specifying namespace for kustomization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant