Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cannot redefine property: id error #132

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

noacohen1
Copy link
Contributor

In my use case, some of the step objects are already containing an id and this line throws an error.

In my use case, some of the step objects are already containing an id and this line throws an error.
@noacohen1 noacohen1 requested a review from AmsterGet as a code owner December 25, 2023 16:47
@AmsterGet
Copy link
Member

Hi @noacohen1 !
Thanks for your contribution.
Could you please describe your use case in more detail?
We encountered that playwright reporter does not provide actual step IDs, so we had to define them manually to avoid name collisions.

@noacohen1
Copy link
Contributor Author

noacohen1 commented Jan 4, 2024

Hi @AmsterGet thanks for the response!
I am not familiar with the reason, i just consume the code, but i see that my 'before', 'before each' steps are already containing an id.
This error is thrown but doesn't harm the report portal launch, the steps are reported correctly.

I think that my code change doesn't harm the current use, if there's no step id the step id will be generated for those who need it, and if there's an id i would't get an error :)

@AmsterGet
Copy link
Member

@noacohen1 thanks!
Will be release in the version.

@AmsterGet AmsterGet merged commit 164a8c7 into reportportal:develop Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants