Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mode setting into a project global #174

Open
ntelfer opened this issue Mar 22, 2019 · 1 comment
Open

Move mode setting into a project global #174

ntelfer opened this issue Mar 22, 2019 · 1 comment
Assignees
Labels
task New feature, request, or update

Comments

@ntelfer
Copy link
Collaborator

ntelfer commented Mar 22, 2019

We need to move away from passing the servers current mode into relevant functions and instead set the mode globally. It is to difficult to enforce that the mode gets passed to all areas of the code base. This is a global setting that the Didery code should only ever read, as such it should be in a globally accessible location.

@ntelfer ntelfer added the task New feature, request, or update label Mar 22, 2019
@ntelfer ntelfer self-assigned this Mar 22, 2019
@ntelfer
Copy link
Collaborator Author

ntelfer commented Mar 22, 2019

Also remove all hard coded strings for the current three modes. ("method", "promiscuous", "race")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task New feature, request, or update
Projects
None yet
Development

No branches or pull requests

1 participant