Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix issue #1292 #7440

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

BPowell76
Copy link

@BPowell76 BPowell76 commented Nov 17, 2024

Fixed issue #1292 with new page creation being incorrectly caught in Regex pattern matching that didn't match a language locale.

The server page helper regex pattern now excludes everything that match a living language as recognized by ISO 639-1. New pages can now be created.

In resolving this issue, the locale Regex pattern matching was removed from the new page modal as it adds the locale to the root of the page path. This made the regex matching redundant.

Closes #1292

image

image

image

…mes 2 characters or less. Removed local regex check as the new page model already prepends the locale.
…'t match individual living languages as acknowledged by ISO 639-1. Removed locales.js file as no longer needed
@auto-assign auto-assign bot requested a review from NGPixel November 17, 2024 20:25
@BPowell76 BPowell76 changed the title Bug: Fix issue https://github.com/requarks/wiki/issues/1292 Bug: Fix issue #1292 Nov 17, 2024
@NGPixel NGPixel added the under review Acknowledged, awaiting further review label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under review Acknowledged, awaiting further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two letter virtual folders mistaken for locales
2 participants