Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when deleting a holdings that still has items with fees #3651

Open
PascalRepond opened this issue Apr 18, 2024 · 0 comments
Open

Error when deleting a holdings that still has items with fees #3651

PascalRepond opened this issue Apr 18, 2024 · 0 comments
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Apr 18, 2024

Bug description:

In the document AND holdings detailed view for serial holdings, there is a button to delete the holdings which also deletes linked items (in cascade) when possible. This button is supposed to be inactive if something prevents the deletion (linked item with active loan, for example).

If the holdings only contains items with a fee as "reason not to delete", the holdings "Delete" button is active and clicking it leads to a system error.

Expected behavior:

In this case, the button should be grayed out, same as if an item in the holdings had an active loan. The tooltip should give the reason(s) not to delete. Example: "has 2 items with fees attached"

image

Steps to Reproduce:

⚠️ Complex to reproduce in test without data manipulation or adding fixtures since it requires a holdings to contain an item with a linked fee.

  • Find a holdings that contains only items without active loans but with pending fees
  • Try to delete the holdings (either from the document detailed view or holdings detailed view)
  • Interface freezes to gray and get error in Sentry: "IlsRecordError.NotDeleted invenio_records_rest.hold_item"

Example in production RBNJ (18.04.2024):
https://bib.rero.ch/professional/records/holdings/detail/1559437
image

Context

  • Versions: v1.21.0
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Apr 18, 2024
@PascalRepond PascalRepond added f: permissions Concerns the rights management UX User experience, ergonomy labels Apr 18, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management UX User experience, ergonomy
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant