Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when displaying a loan if the item has been deleted #3710

Open
PascalRepond opened this issue Jun 26, 2024 · 0 comments · May be fixed by #3786 or #3787
Open

Error when displaying a loan if the item has been deleted #3710

PascalRepond opened this issue Jun 26, 2024 · 0 comments · May be fixed by #3786 or #3787
Assignees
@rerowep
Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry.

Comments

@PascalRepond
Copy link
Contributor

Bug description:

If I delete an item that was linked to a loan, the serialization creates an error if I try to see the loan in the API.
Usually we don't use it but it still creates an error in the API.

Moreover, this can create problems in the interface when displaying past fees linked to this loan (error in the console).

Expected behavior:

  • The serialization for a loan should take into account that the item/document may not exist anymore and say "unknown" when it needs info that doesn't exist anymore OR implement soft delete

Steps to Reproduce:

  1. Find a loan with a fee
  2. Checkin the item and "pay" the fee
  3. Delete the item
  4. Go to the patron profile and check fee history /professional/circulation/patron/[pid]/fees
  5. See console and Sentry error

Example: https://bib.rero.ch/api/loans/412553
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jun 26, 2024
@PascalRepond PascalRepond added the dev: sentry For PRs that are created to correct an error raised by Sentry. label Jun 26, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Jun 26, 2024
@rerowep rerowep self-assigned this Nov 26, 2024
@rerowep rerowep moved this from Product Backlog to In Development in RERO ILS issues Nov 26, 2024
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
04cdd8c 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep linked a pull request Nov 26, 2024 that will close this issue
Open
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
ea235a3 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
f6bd22e 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
ed906e9 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
a3b19b7 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 26, 2024
@rerowep
oauth: add patron pid
53cfb2f 
* Adds `patron_pid` to scope.
* Closes rero#3710.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 27, 2024
@rerowep
loan: fix organisation_pid function
25cba7a 
* Closes rero#3710

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep linked a pull request Nov 27, 2024 that will close this issue
Open
@rerowep rerowep moved this from In Development to Ready to test in RERO ILS issues Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry.
Projects
RERO ILS issues
Status: Ready to test
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oauth: add patron pid rerowep/rero-ils
loan: fix organisation_pid function rerowep/rero-ils
2 participants
@rerowep @PascalRepond