Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth: return patron_pid in the scopes #3778

Closed
PascalRepond opened this issue Nov 14, 2024 · 0 comments · Fixed by #3786
Closed

OAuth: return patron_pid in the scopes #3778

PascalRepond opened this issue Nov 14, 2024 · 0 comments · Fixed by #3786
Assignees
@rerowep
Labels
enhancement Improvement of an existing feature

Comments

@PascalRepond
Copy link
Contributor

How it works

Certain providers need a pid to identify a user and link them to their data (loans, reservations, etc.). Our OAuth implementation returns a barcode but this field can change.

Improvement suggestion

Allow the OAuth server to return the patron.pid somewhere in the scopes so that external services can specifically identify each user.
@PascalRepond PascalRepond added the enhancement Improvement of an existing feature label Nov 14, 2024
@rerowep rerowep moved this from Product Backlog to Ready to test in RERO ILS issues Nov 28, 2024
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
4f14655 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
c34723e 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
c5277af 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
7106e4e 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
8b2939c 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: add patron pid
106a4f0 
* Adds `patron_info` with patron pid for institutions to scope.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 4, 2024
@rerowep
oauth: adds user_id and patron_info
f82935d 
* Adds `user_id`.
* Adds `patron_info` scope with patron pid, patron type, institution
  and expiration_date.
* Marks `patron_types` as deprecated.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Dec 4, 2024
Merged
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 5, 2024
@rerowep
oauth: adds user_id and patron_info
b7c0f4a 
* Adds `user_id`.
* Adds `patron_info` scope with patron pid, patron type, institution
  and expiration_date.
* Marks `patron_types` as deprecated.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 5, 2024
@rerowep
oauth: adds user_id and patron_info
77675a9 
* Adds `user_id`.
* Adds `patron_info` scope with patron pid, patron type, institution
  and expiration_date.
* Marks `patron_types` as deprecated.
* Closes rero#3778.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep closed this as completed in 605a258 Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
enhancement Improvement of an existing feature
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oauth: adds user_id and patron_info rerowep/rero-ils
2 participants
@rerowep @PascalRepond