From 7b5804dbcb3bf2e5df5e3de7a19efd578f6b144a Mon Sep 17 00:00:00 2001
From: Alex Bigelow <alex-r-bigelow@users.noreply.github.com>
Date: Fri, 15 Sep 2023 17:48:14 -0700
Subject: [PATCH] Notes for doing this better in the future

---
 .gitignore                                | 2 +-
 src/_includes/partials/randomAvatars.html | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 26b96ba..799a95e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,4 +5,4 @@ node_modules/
 .vscode/
 *git/
 .env
-src/json/people.json
\ No newline at end of file
+src/static/json/people.json
\ No newline at end of file
diff --git a/src/_includes/partials/randomAvatars.html b/src/_includes/partials/randomAvatars.html
index 91978c0..a066779 100644
--- a/src/_includes/partials/randomAvatars.html
+++ b/src/_includes/partials/randomAvatars.html
@@ -3,7 +3,11 @@
   <script type="application/javascript">
     const teamName = '{{ teamName }}';
     const container = document.querySelector(`[data-team="${teamName}"]`);
-    // TODO: should probably put people.json into src/_data and pre-load the data instead of using fetch
+    // TODO: should probably put people.json into src/_data and pre-load the
+    // data instead of using fetch
+
+    // ... AND should be fetching people.json as part of the local build, not
+    // just github; see also: https://www.11ty.dev/docs/quicktips/eliminate-js/
     fetch('/static/json/people.json')
       .then((response) => response.json())
       .then(({ data }) => {