Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug docker image #2294

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
uses: docker/build-push-action@v5
with:
context: .
file: "docker/Dockerfile"
file: "docker/release.Dockerfile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a convention to use a capital D for the Dockerfile file suffix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's per their documentation

push: ${{ inputs.uploadImageAsTarball != true }}
tags: ${{ steps.meta.outputs.tags }}
load: ${{ inputs.uploadImageAsTarball == true }}
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
uses: docker/build-push-action@v5
with:
context: .
file: "docker/Dockerfile"
file: "docker/release.Dockerfile"
push: true
tags: ${{ steps.meta.outputs.tags }}
load: false
Expand Down
32 changes: 32 additions & 0 deletions docker/debug.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# syntax=docker.io/docker/dockerfile:1.7-labs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't know about this :-)

# Copyright (c) 2023 - Restate Software, Inc., Restate GmbH.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this should be 2024.

# All rights reserved.
#
# Use of this software is governed by the Business Source License
# included in the LICENSE file.
#
# As of the Change Date specified in that file, in accordance with
# the Business Source License, use of this software will be governed
# by the Apache License, Version 2.0.

# This docker file is mainly used to build a local docker image
# with restate binary to run sdk tests

FROM ghcr.io/restatedev/dev-tools:latest AS builder
WORKDIR /usr/src/app
COPY --exclude=.git . .
RUN \
--mount=type=cache,target=/usr/src/app/target,sharing=locked \
--mount=type=cache,target=/usr/src/app/cargo-home,sharing=locked \
du -sh target && du -sh cargo-home && \
CARGO_HOME=/usr/src/app/cargo-home just libc=gnu build --bin restate-server && \
cp target/debug/restate-server restate-server && \
du -sh target && du -sh cargo-home

# We do not need the Rust toolchain to run the server binary!
FROM debian:bookworm-slim AS runtime
COPY --from=builder /usr/src/app/restate-server /usr/local/bin
# copy OS roots
COPY --from=builder /etc/ssl /etc/ssl
WORKDIR /
ENTRYPOINT ["/usr/local/bin/restate-server"]
5 changes: 5 additions & 0 deletions docker/debug.Dockerfile.dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**/.idea
docker/Dockerfile
**/target
restate.tar
charts
File renamed without changes.
File renamed without changes.
7 changes: 5 additions & 2 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ docker_repo := "localhost/restatedev/restate"
docker_tag := if path_exists(justfile_directory() / ".git") == "true" {
`git rev-parse --abbrev-ref HEAD | sed 's|/|.|g'` + "." + `git rev-parse --short HEAD`
} else {
"unknown"
"latest"
}
docker_image := docker_repo + ":" + docker_tag

Expand Down Expand Up @@ -135,7 +135,10 @@ verify: lint test doctest
docker:
# podman builds do not work without --platform set, even though it claims to default to host arch
docker buildx build . --platform linux/{{ _docker_arch }} --file docker/Dockerfile --tag={{ docker_image }} --progress='{{ DOCKER_PROGRESS }}' --build-arg RESTATE_FEATURES={{ features }} --load
docker buildx build . --platform linux/{{ _docker_arch }} --file docker/release.Dockerfile --tag={{ docker_image }} --progress='{{ DOCKER_PROGRESS }}' --build-arg RESTATE_FEATURES={{ features }} --load
debug-docker:
docker buildx build . --file docker/debug.Dockerfile --tag={{ docker_image }} --progress='{{ DOCKER_PROGRESS }}' --build-arg RESTATE_FEATURES={{ features }} --load
notice-file:
cargo license -d -a --avoid-build-deps --avoid-dev-deps {{ _features }} | (echo "Restate Runtime\nCopyright (c) 2024 Restate Software, Inc., Restate GmbH <[email protected]>\n" && cat) > NOTICE
Expand Down
Loading