-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client request extensions don't throw #1692
Comments
Released in 107.0.3 |
The issue seems to be present in DownloadStreamAsync in v107.3.0 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Shouldn't be closed... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Shouldn't be closed and should be fixed. |
The issue is quite trivial to fix, I am wondering why no one opens a PR to get rid of this issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Don't think this ever got fixed. |
It wasn't, but who supposes to fix it? I see you @m1dst commented quite a lot on this, have you considered spending 20 min of your time fixing it? |
I see there is a PR that is open which is related to this. #2128 |
They weren't linked, I am checking with the PR author if it addresses this issue. |
Extensions like
GetAsync
orPostAsync
should throw if the request wasn't successful.However, it doesn't happen. The reason seems to be that the
RestResponse
instance gets the correct status (error), but doesn't get any exception set because of that. And,ThrowIfError
only checks the exception, ignoring the status.The text was updated successfully, but these errors were encountered: