Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Errors on editing metadata to an image #14

Open
admbeck opened this issue Aug 14, 2024 · 4 comments
Open

Bug: Errors on editing metadata to an image #14

admbeck opened this issue Aug 14, 2024 · 4 comments
Labels
bug response required Requires a response from the user that opened the issue

Comments

@admbeck
Copy link

admbeck commented Aug 14, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Open an imported image and edit tags
  2. Click Done to save changes
  3. Various errors appear on the screen and in the terminal
  4. After several repeated clicks metadata saves successfully

Expected behavior
For metadata to be written on first click without errors

Screenshots
Error 1

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value
#0      State.context (package:flutter/src/widgets/framework.dart:958)
#1      _ImageManagerViewState._submit (package:localbooru/views/image_manager/index.dart:111)
<asynchronous suspension>

Error 2

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: FormatException: Unexpected end of input (at character 1)

^

#0      _ChunkedJsonParser.fail (dart:convert-patch/convert_patch.dart:1380)
#1      _ChunkedJsonParser.close (dart:convert-patch/convert_patch.dart:498)
#2      _parseJson (dart:convert-patch/convert_patch.dart:36)
#3      JsonDecoder.convert (dart:convert/json.dart:610)
#4      JsonCodec.decode (dart:convert/json.dart:216)
#5      jsonDecode (dart:convert/json.dart:155)
#6      Booru.getRawInfo (package:localbooru/api/readable.dart:15)
<asynchronous suspension>
#7      Booru.getImage (package:localbooru/api/readable.dart:25)
<asynchronous suspension>
#8      Booru.getImagesFromRange (package:localbooru/api/readable.dart:66)
<asynchronous suspension>
#9      Booru.getImagesFromIndex (package:localbooru/api/readable.dart:80)
<asynchronous suspension>
#10     Booru.searchByTags (package:localbooru/api/readable.dart:96)
<asynchronous suspension>
#11     _GalleryViewerState._obtainResults (package:localbooru/views/navigation/tag_browse.dart:110)
<asynchronous suspension>

Error 3

flutter: Another exception was thrown: Instance of 'DiagnosticsProperty<void>'

System information:
Device 1

  • Device: Desktop
  • OS: Arch Linux
  • Package: Binary
  • Version 1.5.2

Device 2

  • Device: Desktop
  • OS: Windows 10
  • Package: Installer
  • Version 1.5.2

Additional context
Errors appear on both windows and linux versions of the application

@admbeck
Copy link
Author

admbeck commented Aug 16, 2024

Error 3 occurs when an extra space is present in one of the tag fields. If there are spaces in multiple tag types then image won't be saved and there are no error messages.

@admbeck admbeck changed the title Errors on saving metadata to an image Bug: Errors on saving metadata to an image Aug 19, 2024
@admbeck
Copy link
Author

admbeck commented Aug 21, 2024

image

@resucutie resucutie changed the title Bug: Errors on saving metadata to an image Bug: Errors on editing metadata to an image Aug 21, 2024
@resucutie
Copy link
Owner

Some things:

  • For error 1 I have no idea how the hell is that even happening but I also hope it won't happen on 1.6.0 since I reworked the saving system
  • Error 2 I have not much context. From what it seems it is a parsing error when the gallery view tries to read it
  • For error 3, on 1.6.0 it probably won't happen since I've implemented a filter for empty tags,

So I am hoping all of it is already fixed, tho I've personally saw issues related to flashing errors when editing images, but my memory is foggy when it comes to "when"

@resucutie
Copy link
Owner

May you test if images get edited on 1.6.0-prerelease1?

@resucutie resucutie added the response required Requires a response from the user that opened the issue label Sep 1, 2024
@resucutie resucutie added the bug label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug response required Requires a response from the user that opened the issue
Projects
None yet
Development

No branches or pull requests

2 participants