From e0423f698471ad685c6f2b3f4bdbe4b85d29afce Mon Sep 17 00:00:00 2001 From: Reuben Miller Date: Wed, 24 Apr 2024 18:03:06 +0200 Subject: [PATCH 1/2] feat: hide sensitive info by default --- pkg/config/cliConfiguration.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/config/cliConfiguration.go b/pkg/config/cliConfiguration.go index 4de2a469a..a4ec3ea02 100644 --- a/pkg/config/cliConfiguration.go +++ b/pkg/config/cliConfiguration.go @@ -484,7 +484,7 @@ func (c *Config) bindSettings() { WithBindEnv(SettingsViewColumnPadding, 15), WithBindEnv(SettingsViewRowMode, "truncate"), - WithBindEnv(SettingsLoggerHideSensitive, false), + WithBindEnv(SettingsLoggerHideSensitive, true), WithBindEnv(SettingsCacheMethods, "GET PUT POST DELETE"), WithBindEnv(SettingsCacheKeyHost, true), From 6ed693c507b13432cc873aa1ab2e797e48df0cb6 Mon Sep 17 00:00:00 2001 From: Reuben Miller Date: Thu, 25 Apr 2024 07:49:30 +0200 Subject: [PATCH 2/2] test: use cockpit for testing --- .../applications_createHostedApplication.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/manual/applications/createHostedApplication/applications_createHostedApplication.yaml b/tests/manual/applications/createHostedApplication/applications_createHostedApplication.yaml index 27846bd52..b93015ccb 100644 --- a/tests/manual/applications/createHostedApplication/applications_createHostedApplication.yaml +++ b/tests/manual/applications/createHostedApplication/applications_createHostedApplication.yaml @@ -7,27 +7,27 @@ config: tests: Create hosted (web) application overriding an existing application: command: | - c8y applications createHostedApplication --name devicemanagement --dry + c8y applications createHostedApplication --name cockpit --dry exit-code: 0 stdout: json: method: POST path: /application/applications - body.name: devicemanagement - body.contextPath: devicemanagement - body.key: devicemanagement-application-key + body.name: cockpit + body.contextPath: cockpit + body.key: cockpit-application-key body.type: HOSTED body.resourcesUrl: / Create hosted (web) application from folder: command: | - c8y applications createHostedApplication --name devicemanagement --file "./manual/applications/createHostedApplication/simple-helloworld" --dry --skipUpload + c8y applications createHostedApplication --name cockpit --file "./manual/applications/createHostedApplication/simple-helloworld" --dry --skipUpload exit-code: 0 stdout: json: method: POST path: /application/applications - body.name: devicemanagement + body.name: cockpit body.contextPath: custom-app body.key: custom-app-key body.type: HOSTED