Bump the maven group with 3 updates #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the maven group with 3 updates: [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml), org.slf4j:slf4j-simple and [org.apache.maven.plugins:maven-scm-publish-plugin](https://github.com/apache/maven-scm-publish-plugin). Updates `org.codehaus.plexus:plexus-xml` from 3.0.0 to 4.0.4 - [Release notes](https://github.com/codehaus-plexus/plexus-xml/releases) - [Commits](codehaus-plexus/plexus-xml@plexus-xml-3.0.0...plexus-xml-4.0.4) Updates `org.slf4j:slf4j-simple` from 1.7.36 to 2.0.13 Updates `org.apache.maven.plugins:maven-scm-publish-plugin` from 3.2.1 to 3.3.0 - [Commits](apache/maven-scm-publish-plugin@maven-scm-publish-plugin-3.2.1...maven-scm-publish-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-xml dependency-type: direct:production update-type: version-update:semver-major dependency-group: maven - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:development update-type: version-update:semver-major dependency-group: maven - dependency-name: org.apache.maven.plugins:maven-scm-publish-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: maven ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@hazendaz In 57b4ca2, you switched to commons-logging, instead of redirecting it to use slf4j. In the commit message you mentioned that commons-logging is "bad from the beyond", which I read as "bad enough that we should avoid using it", but instead, you used it. Can you help me understand why? You also switched to using slf4j 1.7.36 instead of the newer slf4j2, which the jcl-over-slf4j dependency was using. Can you help me understand why we should stay on slf4j 1.7 instead of move to slf4j 2? Because I'm inclined to prefer slf4j2, in order to get the best support from upstream, and it's nearly entirely backwards compatible with slf4j 1.7 anyway. (Not to mention dependabot is going to keep complaining, like it's doing here) |
|
Sorry meant back from beyond. Commons logging is going to replace jcl over slf4j and spring jcl at some point.
Reason slf4j 1 is due to maven. It's using 1 but maybe that doesn't matter here. I'd prefer 2 as well.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Friday, June 28, 2024 5:19:32 PM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Mention ***@***.***>
Subject: Re: [revelc/formatter-maven-plugin] Bump the maven group with 3 updates (PR #910)
@hazendaz<https://github.com/hazendaz> In 57b4ca2<57b4ca2>, you switched to commons-logging, instead of redirecting it to use slf4j. In the commit message you mentioned that commons-logging is "bad from the beyond", which I read as "bad enough that we should avoid using it", but instead, you used it. Can you help me understand why?
You also switched to using slf4j 1.7.36 instead of the newer slf4j2, which the jcl-over-slf4j dependency was using. Can you help me understand why we should stay on slf4j 1.7 instead of move to slf4j 2? Because I'm inclined to prefer slf4j2, in order to get the best support from upstream, and it's nearly entirely backwards compatible with slf4j 1.7 anyway. (Not to mention dependabot is going to keep complaining, like it's doing here)
—
Reply to this email directly, view it on GitHub<#910 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI4VBYHBH5LHU5B4P3TZJXHOJAVCNFSM6AAAAABJZ3SKKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGY3TKOJVGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the maven group with 3 updates: org.codehaus.plexus:plexus-xml, org.slf4j:slf4j-simple and org.apache.maven.plugins:maven-scm-publish-plugin.
Updates
org.codehaus.plexus:plexus-xmlfrom 3.0.0 to 4.0.4Release notes
Sourced from org.codehaus.plexus:plexus-xml's releases.
... (truncated)
Commits
f25521b[maven-release-plugin] prepare release plexus-xml-4.0.443dbdcaAllow nulls for write elements in MXSerializer6bccd34Bump org.codehaus.plexus:plexus from 17 to 18 (#39)d84cafeBump org.codehaus.plexus:plexus from 16 to 17 (#35)e0a1841Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (#37)4ee6e63---d56dbc9Config release-drafter on masterb97a574Fix release-drafter config14d3067Fix release-drafter config1977a0bFix release-drafter configUpdates
org.slf4j:slf4j-simplefrom 1.7.36 to 2.0.13Updates
org.apache.maven.plugins:maven-scm-publish-pluginfrom 3.2.1 to 3.3.0Commits
53cb318[maven-release-plugin] prepare release maven-scm-publish-plugin-3.3.012afe10[MSCMPUB-69] ITs do not properly check for existence of svn/svnadmin/CreateSy...1b4a3ed[MSCMPUB-68] Upgrade plugins and components (in ITs)f0d13f8[MSCMPUB-67] Upgrade to Maven 3.6.3b7c8c15Add more ignores80796c5Bump org.apache.maven.plugins:maven-plugins from 41 to 42 (#36)5bcd155[MSCMPUB-66] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.0 (#26)0baf493Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.01eb0e43Bump releasePluginVersion from 3.0.0 to 3.0.16aec610[MSCMPUB-65] Bump commons-io:commons-io from 2.11.0 to 2.16.0 (#32)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions