Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a plugin store #4

Open
oddbyte opened this issue Dec 19, 2024 · 9 comments
Open

Add a plugin store #4

oddbyte opened this issue Dec 19, 2024 · 9 comments
Labels
feature New feature or request priority: p2 This is an important issue. It should be fixed very soon.

Comments

@oddbyte
Copy link

oddbyte commented Dec 19, 2024

There was a plugin called Plugin Browser for bunny, but that wasn't a built-in behavior. I'd like to see a built in plugin store in the client.

@PalmDevs PalmDevs added feature New feature or request priority: p2 This is an important issue. It should be fixed very soon. labels Dec 19, 2024
@oSumAtrIX
Copy link
Member

I'm unsure how much we can realize this because it conflicts with decentralization. At least the default source needs to be environment configurable in source.

@true1ann
Copy link
Contributor

it conflicts with decentralization.

You can just have list of repos to gather infos from, with the last in the list being the most preffered source, no?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 24, 2024

No, because then we still have a central opinionated list, regardless of ordering that conflicts with decentralization.

@Ushie
Copy link

Ushie commented Jan 6, 2025

You can be decentralised and still offer defaults, make the sources customizable and ship with our default source, users can add or delete sources as they choose

This behavior can also be found in ReVanced's upcoming update to their manager

@oSumAtrIX
Copy link
Member

This is correct. The default can be configured via an env variable during publication. The source remains independent of any specific default.

@oddbyte
Copy link
Author

oddbyte commented Jan 6, 2025

You should also add a way to change the signing key required for plugins to be verified as "trusted"

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 6, 2025

If you're using the revenge distribution of the source code, the environment will configure revenge to be trusted as part of you already trusting this distro. Changing the key doesn't make sense, however you can trust other developers keys anyway in the first place, but you can't not trust revenge if you're using revenge as the distro. If you don't want to trust revenge, dont use revenge as the distribution and compile the source with your env or someone else

@oddbyte
Copy link
Author

oddbyte commented Jan 14, 2025

You could still add the option to not trust it, and / or put your own signing key to replace Revenge's (for the like two people who are extremely privacy focused but are too lazy to recompile)

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 14, 2025

This is illogical. If you run a distribution by Revenge you automatically trust it already. Not trusting the signature implies not trusting the distro as the signatory is the same. "Too lazy" and "extremely privacy focused" is mutually exclusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request priority: p2 This is an important issue. It should be fixed very soon.
Projects
None yet
Development

No branches or pull requests

5 participants