Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context is missing information for ActionLogic errors #13

Open
rewinfrey opened this issue Dec 18, 2018 · 0 comments
Open

context is missing information for ActionLogic errors #13

rewinfrey opened this issue Dec 18, 2018 · 0 comments

Comments

@rewinfrey
Copy link
Owner

When an ActionLogic error is thrown, the intent is to communicate the context in which the error was thrown (i.e. the name of the specific class). Instead the context today reports a generic catchall Class:

ActionLogic::AttributeTypeError: context: Class message: Attribute: integer_test with value:  was expected to be of type Fixnum but is NilClass

The issue is not threading the executionContext from ActionCore through to the ActionValidation methods. If executionContext is passed as an argument, when we find an error within any of the ActionValidation methods we would have the originating class information for producing a better error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant