Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'&' in remotefilter is not properly URL serialized #307

Open
lunarmoon26 opened this issue Apr 16, 2021 · 1 comment
Open

'&' in remotefilter is not properly URL serialized #307

lunarmoon26 opened this issue Apr 16, 2021 · 1 comment
Assignees
Labels

Comments

@lunarmoon26
Copy link

lunarmoon26 commented Apr 16, 2021

Version:

2.2.1

Issue:

For example giving the following service call:

Service<Resource>.all({
  remotefilter: {
    field: "foo&bar"
  }
})

The serialized URL will be:

...?filter[field]=foo&bar

which isn't correct. The work around is to manually encrypt the string before passing to the filter. This isn't very robust as the developer may forget to do so

Solution:

URL encrypt the string field (encodeURIComponent) by default and provide an option to override?

@pablorsk
Copy link
Member

pablorsk commented Apr 16, 2021

Solution:

  • URL encrypt the string field (encodeURIComponent) by default

PR with jest test are welcome. On 15 days, if the problem has not been solved, @ahumadamatias will fix it (FE-261).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants